Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path based routing #215

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Path based routing #215

merged 7 commits into from
Apr 18, 2024

Conversation

vinnyjth
Copy link
Member

🐛 Issue

We are running into unresolvable issues on Liquid, and want to support path based routing for better SEO optimization

✏️ Solution

  1. Abstract all navigation actions into a navigation hook.
  2. Inside that navigation hook, navigate using alternative strategies depending on the current type of auth enabled
  3. Abstract out the current "id" so it can come from a variety of sources - params, feed id, or content id
    • Right now we have two paths /ac/ and /af/. Technically both are identical, but may come in handy as we continue to iterate on our routing strategy.
  4. Ditch breadcrumbs

🔬 To Test

in the web-embeds site

  1. Click around the app.
  2. Navigation will happen via path
  3. Now change data-use-path-router="true" to data-use-path-router="false" in the index.html
  4. Navigate around the app
  5. Navigation will happen via params.

📸 Screenshots

CleanShot 2024-04-17 at 16 20 38@2x

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apollos-micro-service ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 7:32pm
apollos-web-embeds ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 7:32pm

@vinnyjth
Copy link
Member Author

Merging 🤞

@vinnyjth vinnyjth merged commit 51fefc9 into main Apr 18, 2024
5 checks passed
@vinnyjth vinnyjth deleted the path-based-routing branch April 18, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants